Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant snapshot_id from SetStatisticsUpdate #1566

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Remove redundant snapshot_id from SetStatisticsUpdate #1566

merged 3 commits into from
Jan 24, 2025

Conversation

ndrluis
Copy link
Collaborator

@ndrluis ndrluis commented Jan 23, 2025 •
edited
Loading

Closes #1556

@ndrluis ndrluis requested review from Fokko and sungwy January 23, 2025 18:24
@ndrluis ndrluis marked this pull request as ready for review January 23, 2025 18:24
@ndrluis ndrluis requested a review from kevinjqliu January 23, 2025 18:24
Fokko
Fokko approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ndrluis for following up on this so quickly! 🚀

pyiceberg/table/update/__init__.py Outdated Show resolved Hide resolved
@ndrluis
Copy link
Collaborator Author

ndrluis commented Jan 24, 2025

@Fokko Done!

@Fokko Fokko merged commit 3b53edc into apache:main Jan 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko approved these changes

@sungwy sungwy Awaiting requested review from sungwy

@kevinjqliu kevinjqliu Awaiting requested review from kevinjqliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate snapshot-id of SetStatisticsUpdate
2 participants
@ndrluis @Fokko